Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identify structural trees on Match Type qualifiers #18765

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Identify structural trees on Match Type qualifiers #18765

merged 2 commits into from
Oct 27, 2023

Conversation

dwijnand
Copy link
Member

Without this change, selecting v1 on a type Ifce[(true : Boolean)]#RT which widens to a MatchType wouldn't be identified as a
structural tree, which later breaks Erasure.

@dwijnand
Identify structural trees on Match Type qualifiers
ff90012 
Without this change, selecting `v1` on a type `Ifce[(true :
Boolean)]#RT` which widens to a MatchType wouldn't be identified as a
structural tree, which later breaks Erasure.
@dwijnand dwijnand linked an issue Oct 26, 2023 that may be closed by this pull request
AST owner loss during a type match #17192
Closed
@dwijnand dwijnand marked this pull request as ready for review October 27, 2023 09:12
@dwijnand dwijnand requested a review from sjrd October 27, 2023 09:12
sjrd
sjrd reviewed Oct 27, 2023
View reviewed changes
tests/neg/i17192.5.scala Show resolved Hide resolved
tests/neg/i17192.5.scala Outdated Show resolved Hide resolved
@dwijnand @sjrd
Align pos and neg test pair
cc69d90 
Co-authored-by: Sébastien Doeraene <sjrdoeraene@gmail.com>
@dwijnand dwijnand merged commit c0eae68 into scala:main Oct 27, 2023
18 checks passed
@dwijnand dwijnand deleted the bare-select branch October 27, 2023 15:31
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
@WojciechMazur WojciechMazur mentioned this pull request Jun 22, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jun 23, 2024
@WojciechMazur
Backport "Identify structural trees on Match Type qualifiers" to LTS (#…
4fc36bc 
…20744)

Backports #18765 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjrd sjrd sjrd approved these changes

Assignees

@sjrd sjrd

Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

AST owner loss during a type match
3 participants
@dwijnand @sjrd @Kordyjan