Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CC: Give more info when context function parameters leak #20244

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Apr 21, 2024

Previously we had:

parameter $contextual1 leaks into outer capture set of type parameter T of method apply.

We now give info in what type the parameter appeared and who owns the method. It's still not great, but at least we see more info that could tell us about the context.

Previously we had:

  parameter `$contextual1` leaks into outer capture set of type parameter `T` of method `apply`.

We now give info in what type the parameter appeared and who owns the method.
It's still not great, but at least we see more info that could tell us about the context.
@odersky odersky added the cc-experiment Intended to be merged with cc-experiment branch on origin label Apr 21, 2024
@Gedochao Gedochao added the area:experimental:cc Capture checking related label Apr 22, 2024
@odersky odersky requested a review from noti0na1 April 24, 2024 10:34
@odersky odersky assigned noti0na1 and unassigned natsukagami Apr 24, 2024
Copy link
Member

@noti0na1 noti0na1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@odersky odersky merged commit 96c956a into scala:main Apr 24, 2024
19 checks passed
@odersky odersky deleted the improve-leak-msg branch April 24, 2024 16:13
@Kordyjan Kordyjan added this to the 3.5.0 milestone May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:experimental:cc Capture checking related cc-experiment Intended to be merged with cc-experiment branch on origin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants