Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport "Fix a bundle of patmat issues" to 3.5.2 #21478

Merged
merged 11 commits into from
Aug 28, 2024
Merged

Backport "Fix a bundle of patmat issues" to 3.5.2 #21478

merged 11 commits into from
Aug 28, 2024

Commits on Aug 28, 2024

  1. Re-fix skipping match analysis & inlining 

    [Cherry-picked 4f22672]
    @dwijnand @WojciechMazur
    dwijnand authored and WojciechMazur committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    df3bc28 View commit details
    Browse the repository at this point in the history

  2. Fix PrefixSetting 

    [Cherry-picked 3ba51a6]
    @dwijnand @WojciechMazur
    dwijnand authored and WojciechMazur committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    c99c125 View commit details
    Browse the repository at this point in the history

  3. Childless 

    [Cherry-picked 5994ea7]
    @dwijnand @WojciechMazur
    dwijnand authored and WojciechMazur committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    872d3e0 View commit details
    Browse the repository at this point in the history

  4. Fix a bundle of patmat issues 

    Some of the issues are legitimate

[Cherry-picked b56da91]
    @dwijnand @WojciechMazur
    dwijnand authored and WojciechMazur committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    54fc155 View commit details
    Browse the repository at this point in the history

  5. Detail why not baseType 

    [Cherry-picked 7183bb2]
    @dwijnand @WojciechMazur
    dwijnand authored and WojciechMazur committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    938c5bb View commit details
    Browse the repository at this point in the history

  6. Strip null in exhaustivityCheckable 

    [Cherry-picked 8df91fa]
    @dwijnand @WojciechMazur
    dwijnand authored and WojciechMazur committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    4d58216 View commit details
    Browse the repository at this point in the history

  7. Fix SeqFactoryClass#unapplySeq 

    Previously `defn.ListType.appliedTo(elemTp) <:< pat.tpe` failed when
pat.tpe is something like ParamClause, an alias.

[Cherry-picked e160de7]
    @dwijnand @WojciechMazur
    dwijnand authored and WojciechMazur committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    6a1b684 View commit details
    Browse the repository at this point in the history

  8. Strip null on the scrutinee 

    Without that, we end up with either a flexible type or a `| Null`.

[Cherry-picked 5fd810e]
    @dwijnand @WojciechMazur
    dwijnand authored and WojciechMazur committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    48f9c67 View commit details
    Browse the repository at this point in the history

  9. Maximise once more 

    [Cherry-picked 4dd8e8a]
    @dwijnand @WojciechMazur
    dwijnand authored and WojciechMazur committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    aef1e2e View commit details
    Browse the repository at this point in the history

  10. Detail the second-pass maximizeType in Space.signature 

    [Cherry-picked 5b425ee]
    @dwijnand @WojciechMazur
    dwijnand authored and WojciechMazur committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    70ead5c View commit details
    Browse the repository at this point in the history

  11. Only strip under unsafeNulls 

    [Cherry-picked ab240f1]
    @dwijnand @WojciechMazur
    dwijnand authored and WojciechMazur committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    40c60d8 View commit details
    Browse the repository at this point in the history