Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

analyze object when selecting from package #21511

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

EnzeXing
Copy link
Contributor

This PR is an updated version of #20424, which fixes a bug in the global initialization checker such that when accessing global object through full path, the checker immediately analyzes the initialization code of the corresponding object.

[test_scala2_library_tasty]

@EnzeXing
Copy link
Contributor Author

@liufengyun @olhotak test_scala2_library_tasty shows the extra warnings that we have seen have when analyzing with scala2 library tasty. The initialization cycle object Predef -> package object scala -> object IndexedSeq -> object Vector -> object Predef should be already fixed when using the latest version of scala2-library-tasty. Cyclic initialization: object Predef -> object Manifest -> object ManifestFactory -> object Predef should be fixed after we merge #21523. I think it's safe to merge this PR, and possibly conclude issue #18882.

@liufengyun
Copy link
Contributor

@EnzeXing Thank you. I just approved the other PR.

In order to avoid breaking the nightly build, we can add some of the tests to a blacklist if they cannot be reasonably adapted:

This way, we will be sure that the test test_scala2_library_tasty will be green.

@EnzeXing
Copy link
Contributor Author

EnzeXing commented Sep 1, 2024

I have updated the blacklist and now the tests passed.

Copy link
Contributor

@olhotak olhotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olhotak olhotak merged commit 0e17117 into scala:main Sep 3, 2024
28 checks passed
@olhotak olhotak deleted the fix-access-object branch September 3, 2024 13:19
@WojciechMazur WojciechMazur added this to the 3.6.0 milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants