Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: Make sure Scala CLI tests are less flaky #21570

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Sep 9, 2024

The expected list should be stable and we only check if the expected subset is contained

The expected list should be stable and we only check if the expected subset is contained
Copy link
Member

@hamzaremmal hamzaremmal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a big improvement but I still think that we need to have a very clear policy on what are we allowed to add in the tests

@tgodzik
Copy link
Contributor Author

tgodzik commented Sep 10, 2024

What could be a potential policy? I can remove the tests if this is a problem.

@tgodzik tgodzik merged commit 7d12783 into scala:main Sep 10, 2024
28 checks passed
@rochala
Copy link
Contributor

rochala commented Sep 10, 2024

Wouldn't it be best if we completely remove dependency on coursier and provide CoursierCompletions via interface, just like we do with Symbol search ?

@hamzaremmal
Copy link
Member

hamzaremmal commented Sep 10, 2024

What could be a potential policy? I can remove the tests if this is a problem.

@tgodzik In my opinion, we should not use dependencies outside of our control. For these tests, (if its not possible to test with some mock system) we can publish some kind of dummy library on Maven Central and use it instead of using com.lihaoyi::pprint, io.circe::circe-core, ...

@tgodzik tgodzik deleted the improve-scalacli branch September 10, 2024 08:17
@tgodzik
Copy link
Contributor Author

tgodzik commented Sep 10, 2024

Wouldn't it be best if we completely remove dependency on coursier and provide CoursierCompletions via interface, just like we do with Symbol search ?

Probably yeah. Or just use symbol search, add searchDependency method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants