Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert pattern matching improvements introducing regressions in 3.3.4 #21573

Merged

Conversation

WojciechMazur
Copy link
Contributor

@WojciechMazur WojciechMazur commented Sep 10, 2024

This change reverts pattern-matching improvements backported to 3.3.4 but causes new regressions.
The goal is to unblock the 3.3.4 release in case a proper fix to #21569 would not be possible to achive in a short period of time.

Reverts fully #21549 (with exception of i21218 test case reproducer) to mitigate regressions of #21569
Reverts single (major) commit from #20669 - 333fa6c and adapts tests to mitigate regression introduced in #21218

@dwijnand
Copy link
Member

Do you want to add tests/warn/i21218.scala from PR #21532 ?

@WojciechMazur
Copy link
Contributor Author

Do you want to add tests/warn/i21218.scala from PR #21532 ?

This one is already present in the release-3.3.4 branch. It was backported in #21549, it's the only not reverted commit from that PR to ensure the regression is fixed

@WojciechMazur WojciechMazur marked this pull request as ready for review September 11, 2024 09:51
@WojciechMazur WojciechMazur merged commit 000c52d into scala:release-3.3.4 Sep 11, 2024
17 checks passed
@WojciechMazur WojciechMazur deleted the 3.3.4-RC2-21000-18377 branch September 11, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants