Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quotes around Windows command line arguments passed to JVM #21575

Conversation

GuntherRademacher
Copy link

Command line arguments passed to the JVM need to be quoted, otherwise some special characters, e.g. ")" will be interpreted in the script and cause it to fail.

This happened to me while testing with 3.3.3, so I would appreciate it to be fixed in 3.3.4.

Command line arguments passed to the JVM need to be quoted, otherwise some special characters, e.g. ")" will be interpreted in the script and cause it to fail.
@WojciechMazur WojciechMazur deleted the branch scala:release-3.3.4 October 8, 2024 14:24
@tgodzik
Copy link
Contributor

tgodzik commented Oct 8, 2024

Could you reopen the PR against the main branch? This got claused automatically by github since the branch was deleted, we backport most of the changes to LTS ourselves

@GuntherRademacher
Copy link
Author

Could you reopen the PR against the main branch? This got claused automatically by github since the branch was deleted, we backport most of the changes to LTS ourselves

@tgodzik This only affects scala.bat, which is completely different in 3.5+. In particular it does not contain the bug that I reported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants