Make benchmarks depend only on library classpath #5024
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The classpath is intended for type checking, not for compiler run-time. Thus, they should be passed as compiler options, not JVM options. It works before because the compiler makes bootstrap classpath available for type checking. However, we can no longer use bootstrap classpath after Java 9 support (scala#3138).
Testing that our benchmark program don't need to link against the compiler. Warning: This might make performance incomparable with earlier (similarly to other current changes.
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 1 running. |
|
performance test failed: Please check http://lamppc37.epfl.ch:8000/pull-5024-08-26-16.51.out for more information |
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 0 running. |
liufengyun
approved these changes
Aug 27, 2018
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/5024/ to see the changes. Benchmarks is based on merging with master (28ddeac) |
|
Don't merge, there are still 4 failures in benchmarks. I'm investigating.
Le lun. 27 août 2018 10:13, dotty-bot <notifications@github.com> a écrit :
… Performance test finished successfully:
Visit http://dotty-bench.epfl.ch/5024/ to see the changes.
Benchmarks is based on merging with master (28ddeac
<28ddeac>
)
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#5024 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAuDySN8YrLxReNzuEPkkWbFzWQ0CU08ks5uU6pCgaJpZM4WMyWn>
.
|
|
Closing as the idea is now in #5020 and up to @liufengyun. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #5020.
Testing that our benchmark program don't need to link against the compiler.
Warning: This might make performance incomparable with earlier (similarly to
other current changes.