Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WiP] Switch zinc from fork to original one. #1477

Closed
wants to merge 1 commit into from
Closed

[WiP] Switch zinc from fork to original one. #1477

wants to merge 1 commit into from

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Mar 8, 2021

No description provided.

@tgodzik tgodzik changed the title Switch zinc from fork to original one. [WiP] Switch zinc from fork to original one. Mar 8, 2021
@adpi2 adpi2 mentioned this pull request Mar 10, 2021
Closed
5 tasks
@adpi2 adpi2 mentioned this pull request Apr 15, 2021
Closed
@Arthurm1 Arthurm1 mentioned this pull request Jul 25, 2021
Merged
@Arthurm1 Arthurm1 mentioned this pull request Aug 6, 2021
Merged
@tgodzik tgodzik mentioned this pull request Sep 23, 2021
Open
@scalacenter scalacenter deleted a comment from bloopoid Nov 10, 2021
@scalacenter scalacenter deleted a comment from bloopoid Nov 10, 2021
@scalacenter scalacenter deleted a comment from bloopoid Nov 10, 2021
@tgodzik tgodzik force-pushed the update-to-zinc branch 12 times, most recently from 597b0ad to 87f256c Compare November 10, 2021 17:02
@scalacenter scalacenter deleted a comment from bloopoid Nov 10, 2021
@scalacenter scalacenter deleted a comment from bloopoid Nov 10, 2021
@scalacenter scalacenter deleted a comment from bloopoid Nov 10, 2021
@scalacenter scalacenter deleted a comment from bloopoid Nov 10, 2021
@scalacenter scalacenter deleted a comment from bloopoid Nov 10, 2021
@bloopoid
Copy link
Collaborator

performance test scheduled: 1 job(s) in queue, 0 running.

@bloopoid
Copy link
Collaborator

Performance test finished successfully.

Benchmarks is based on merging with master

@tgodzik tgodzik force-pushed the update-to-zinc branch 2 times, most recently from c30d89a to bacaf73 Compare December 3, 2021 22:11
@bloopoid
Copy link
Collaborator

Performance test finished successfully.

Benchmarks is based on merging with master

@tgodzik tgodzik force-pushed the update-to-zinc branch 2 times, most recently from 8507161 to a61662d Compare December 17, 2021 09:57
@tgodzik
Copy link
Contributor Author

tgodzik commented Dec 19, 2021

test performance please

@bloopoid
Copy link
Collaborator

performance test scheduled: 1 job(s) in queue, 0 running.

@tgodzik
Copy link
Contributor Author

tgodzik commented Dec 20, 2021

test performance please

@bloopoid
Copy link
Collaborator

performance test scheduled: 1 job(s) in queue, 0 running.

@tgodzik
Copy link
Contributor Author

tgodzik commented Dec 20, 2021

test performance please

@bloopoid
Copy link
Collaborator

Performance test finished successfully.

Benchmarks is based on merging with master

4 similar comments
@bloopoid
Copy link
Collaborator

Performance test finished successfully.

Benchmarks is based on merging with master

@bloopoid
Copy link
Collaborator

Performance test finished successfully.

Benchmarks is based on merging with master

@bloopoid
Copy link
Collaborator

Performance test finished successfully.

Benchmarks is based on merging with master

@bloopoid
Copy link
Collaborator

Performance test finished successfully.

Benchmarks is based on merging with master

@tgodzik tgodzik force-pushed the update-to-zinc branch 2 times, most recently from 8803d87 to 1ed5c5e Compare December 20, 2021 19:11
@bloopoid
Copy link
Collaborator

Performance test finished successfully.

Benchmarks is based on merging with master

1 similar comment
@bloopoid
Copy link
Collaborator

Performance test finished successfully.

Benchmarks is based on merging with master

@bloopoid
Copy link
Collaborator

Performance test finished successfully.

Benchmarks is based on merging with master

1 similar comment
@bloopoid
Copy link
Collaborator

Performance test finished successfully.

Benchmarks is based on merging with master

@Arthurm1 Arthurm1 mentioned this pull request Dec 23, 2021
Closed
18 tasks
@tgodzik
Switch to the original fork of zinc and remove pipelining.
acca205 
In order to make upgrading versions easier we decided to switch back to sbt/zinc instead of a custom fork. The original reason for using the fork was to enable build pipelining, but that itself has been implemented in the orginal fork.

Unfortunately, to make the migration easier we needed to remove build pipelining for now to later add it with the default mechanism.

Related to scalacenter#1383

The benchmarks are being run to make sure we are not regressing in performance.
@tgodzik
Copy link
Contributor Author

tgodzik commented Jan 21, 2022

Final (probably) PR in #1662

@tgodzik tgodzik closed this Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tgodzik @bloopoid