Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send TestResult to Debugee Listener #1607

Merged
merged 3 commits into from
Dec 3, 2021
Merged

Conversation

kpodsiad
Copy link
Collaborator

Follow-up of scalacenter/scala-debug-adapter#157. Now Bloop sends to the DAP server test result event which contains information about test execution

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments until the scala-debug-adapter is merged

@kpodsiad kpodsiad force-pushed the test-result branch 2 times, most recently from dd50699 to 73a49cf Compare November 23, 2021 13:07
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, but for sure we need to figure out the issues in the scala-debug-adapter PR first

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgodzik tgodzik merged commit f4ef827 into scalacenter:master Dec 3, 2021
@kpodsiad kpodsiad deleted the test-result branch December 3, 2021 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants