Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stabilize test project resources generation #1715

Merged
merged 1 commit into from
Apr 9, 2022
Merged

fix: stabilize test project resources generation #1715

merged 1 commit into from
Apr 9, 2022

Conversation

dos65
Copy link
Collaborator

@dos65 dos65 commented Apr 8, 2022

Fixes the issue that was found by @kpodsiad in #1706 (comment)

@dos65 dos65 force-pushed the resources_gen_fix branch from a07fb17 to 375fbba Compare April 8, 2022 16:56
@kpodsiad kpodsiad mentioned this pull request Apr 9, 2022
Merged
kpodsiad
kpodsiad approved these changes Apr 9, 2022
View reviewed changes
Copy link
Collaborator

@kpodsiad kpodsiad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more words about why this PR is needed.
Previously, if one of the bloop-config directories was removed it wasn't regenerated.
Now, it works like a charm! I tested it locally so LGTM!

@kpodsiad kpodsiad merged commit aab21b1 into scalacenter:main Apr 9, 2022
@kpodsiad kpodsiad mentioned this pull request Apr 9, 2022
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpodsiad kpodsiad kpodsiad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dos65 @kpodsiad