fix: allow for spaces in project name #2311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
approved these changes
Apr 9, 2024
ritschwumm
reviewed
Apr 9, 2024
| @@ -21,7 +23,9 @@ object ProjectUris { | |||
| Left(s"URI '${projectUri}' has invalid format. Example: ${ProjectUris.Example}") | |||
| case Right(parsed) => | |||
| parsed.headOption match { | |||
| case Some(Array("id", projectName)) => Right(state.build.getProjectFor(projectName)) | |||
| case Some(Array("id", projectName)) => | |||
| val name = URLDecoder.decode(projectName, StandardCharsets.UTF_8) | |||
There was a problem hiding this comment.
scala> java.net.URLDecoder.decode("a+a")
val res0: String = a ais the space in the result expected and wanted here?
There was a problem hiding this comment.
Oh, you're right URLDecoder.decode doesn't seem to correctly undo URI.quote.
There was a problem hiding this comment.
We might need to port the class we have in Metals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes scalameta/metals#5745