Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement BSP buildTarget/outputPaths #2323

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Conversation

jturcotte
Copy link
Contributor

This fixes build-server-protocol/build-server-protocol#205 when importing from bloop by reporting the target/ folder of each project as an outputPath.

In my case I am using it with bloop-maven-plugin.

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

Out of curiosity, where do you use this endpoint?

@tgodzik tgodzik merged commit 7f86522 into scalacenter:main Apr 15, 2024
17 checks passed
@jturcotte
Copy link
Contributor Author

My understanding of this comment is that support was added to IntelliJ's Scala plugin a while ago to generate the module settings, but that initially only sbt's BSP server was providing it.

@tgodzik
Copy link
Contributor

tgodzik commented Apr 15, 2024

My understanding of this comment is that support was added to IntelliJ's Scala plugin a while ago to generate the module settings, but that initially only sbt's BSP server was providing it.

Makes sense, I vaguely remember some discussions about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exclude compilation artifacts from searchable files
2 participants