Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Scalatest 3.2.0 #133

Merged
merged 3 commits into from
Jun 21, 2020
Merged

Upgrade to Scalatest 3.2.0 #133

merged 3 commits into from
Jun 21, 2020

Conversation

olafurpg
Copy link
Contributor

Supersedes #131

Fixes the compile errors caused by using the deprecated scala.meta.testkit.DiffAssertions

@olafurpg olafurpg requested a review from bjaglin June 21, 2020 09:39
Copy link
Collaborator

@bjaglin bjaglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh thanks, I completely misdiagnosed #131 (comment) thinking the problem was related to https://github.com/scalacenter/scalafix/blob/v0.9.17/scalafix-testkit/src/main/scala/scalafix/testkit/DiffAssertions.scala and thus scalacenter/scalafix#1172, but there is no scalafix-testkit involved here, neither in the main build or in the scripted tests!

@olafurpg olafurpg merged commit 84cdc0d into scalacenter:master Jun 21, 2020
@olafurpg olafurpg deleted the scalatest branch June 21, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants