scalafixEnable: relax -Xfatal-warnings for scalafix invocations #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scalafixEnable should maximize the chances of getting semanticdb-scalac to run so that semantic rules can run. When enabled in the build, -Xfatal-warnings can be a major obstacle for example when: 1. scalafixEnable forced a newer (patch) Scala version that the one in the build, with improved warning reporting; 2. the user already has a build with fatal deprecation warnings and wants to apply a rewrite rule to fix them.
fthomas
reviewed
Mar 4, 2021
| } | ||
|
|
||
| private def scalafixInvoked: Def.Initialize[Task[Boolean]] = | ||
| Def.task(executionRoots.value.exists(_.key == scalafix.key)) |
There was a problem hiding this comment.
Should this also check for scalafixAll?
There was a problem hiding this comment.
good catch! just added 9c91d70
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes scalacenter/scalafix#1346
scalafixEnableshould maximize the chances of gettingsemanticdb-scalacto run so that semantic rules can run.When enabled in the build,
-Xfatal-warningscan be a major obstacle for example when:scalafixEnableforced a newer (patch) Scala version that the one in the build, with improved warning reporting;