Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix latest-by-scala-version badge summary to prefer releases #1330

Commits on Jan 13, 2024

  1. Fix latest-by-scala-version badge summary to prefer releases

    Currently, for the `content-api-firehose-client`, the Scaladex badges page
    is showing some contrasting values:
    
    https://index.scala-lang.org/guardian/content-api-firehose-client/badges
    
    * The 'Latest version' badge is showing a good version:
      1.0.12
    * The 'JVM badge' (which shows a summary of latest versions by supported
      Scala version, introduced with scalacenter#660)
      is showing an undesireable pre-release version:
      1.0.13-PREVIEW.rt-dbremove-travis-file.2024-01-10T1738.6e259255
    
    You can see both values on the versions page, but only if you tick the
    'Show pre-release versions' button:
    
    * https://index.scala-lang.org/guardian/content-api-firehose-client/artifacts/content-api-firehose-client
    * https://index.scala-lang.org/guardian/content-api-firehose-client/artifacts/content-api-firehose-client?pre-releases=true#
    
    This PR fixes the behaviour on the latest-by-scala-version badge to match the behaviour
    of the other badge - it does this with a new PreferReleases ordering for SemanticVersions.
    rtyley committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    d16cc46 View commit details
    Browse the repository at this point in the history