Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for sbt artifacts in the Scaladex badge #674

Merged
merged 3 commits into from
Jul 5, 2021

Commits on Jul 4, 2021

  1. Better support for sbt artifacts in the Scaladex badge

    Each release of sbt uses a specific version of Scala (1.0 uses Scala 2.12,
    0.13 uses Scala 2.10), so the sbt version of a plugin fully determines the
    Scala language binary version it uses - this means, for a user, it's only
    really interesting to know the sbt version of the plugin, not the Scala
    language version.
    
    At the moment, the Scaladex badge for, eg, the `sbt-assembly` plugin reads
    `1.0.0 (Scala 2.12, 2.10)` - for the user, it would be more helpful if it
    read `1.0.0 (sbt 1.0, 0.13)` - listing the versions of sbt you can actually
    use it with! Although the Scaladex badge did have some logic to display the
    platform versions supported by _all_ listed Scala language versions, that
    doesn't help in this situation, as the Scala language version differs for
    each platform version of sbt. See also this comment from a prior PR:
    
    scalacenter#670 (comment)
    
    This commit updates the Scaladex badge logic to have two version-summary
    strategies:
    
    * `SummariseLanguageVersion` - which was the existing strategy, listing
      notable Scala version support, secondarily adding in a summary of
      platform editions (eg 'Scala 2.13 - Native 0.4+0.3')
    * `SummarisePlatformEdition` - the new strategy, which is used if *all*
      fetched `ScalaTarget`s for an artifact have a `targetType` for which
      the platform version fully determines the Scala version (as is the case
      for sbt). It omits the Scala version from the summary, and just relates
      the platform versions (eg `sbt 1.0, 0.13`)
    rtyley committed Jul 4, 2021
    Configuration menu
    Copy the full SHA
    ce5d9e6 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2021

  1. Update server/src/main/scala/ch.epfl.scala.index.server/BadgesSupport…

    ….scala
    
    Co-authored-by: Adrien Piquerez <adrien.piquerez@gmail.com>
    rtyley and adpi2 authored Jul 5, 2021
    Configuration menu
    Copy the full SHA
    edc8916 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    34949f3 View commit details
    Browse the repository at this point in the history