Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document scalafixAll InputKey #1160

Merged
merged 1 commit into from
Jul 2, 2020
Merged

Conversation

bjaglin
Copy link
Collaborator

@bjaglin bjaglin commented Jun 13, 2020

Merge only when scalacenter/sbt-scalafix#126 is released

Copy link
Contributor

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 scalafixAll is a huge improvement in the UX! Time to update my builds to remove scalafixAll aliases


### Integration tests

By default, the `scalafix` command is enabled for the `Compile` and `Test`
configurations. To enable Scalafix for other configuration like
`IntegrationTest`, add the following to your project settings
configurations, ans `scalafixAll` will run on both of them. To enable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Suggested change
configurations, ans `scalafixAll` will run on both of them. To enable
configurations, and `scalafixAll` will run on both of them. To enable

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

```
Both the `scalafix` & the `scalafixAll` task aggregate like the `compile`
and `test` tasks. To run Scalafix on all projects for both main and test
sources you can execute `all scalafix test:scalafix` or simply `scalafixAll`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like the easiest to explain option and it handles custom integrations like it:scalafix

Suggested change
sources you can execute `all scalafix test:scalafix` or simply `scalafixAll`.
sources you can execute `scalafixAll`.

Is there a difference between all scalafixAll and only scalafixAll?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed 👍

Is there a difference between all scalafixAll and only scalafixAll?

None as in both cases, configurations invocations will run independently/concurrently. I guess the latter allows a single last scalafixAll to see an overview of the logs easily. And the former is a command while the latter is a task obviously. Why do you ask?

@bjaglin
Copy link
Collaborator Author

bjaglin commented Jun 14, 2020

Commit amended with the suggestions 👍

@bjaglin bjaglin merged commit f0c793b into scalacenter:master Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants