Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mdoc, sbt-mdoc to 2.3.0 #1531

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

scala-steward
Copy link
Contributor

Updates

from 2.2.24 to 2.3.0.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scalameta" } ]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

@@ -21,7 +21,11 @@ object PatchDocs {
colorLiteral = fansi.Attrs.Empty,
colorApplyPrefix = fansi.Attrs.Empty
) {
override def treeify(x: Any): pprint.Tree = {
override def treeify(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bjaglin
Copy link
Collaborator

bjaglin commented Feb 9, 2022

[info] running (fork) docs.Main 
[error] Exception in thread "main" java.util.ServiceConfigurationError: scalafix.v1.Rule: Provider scalafix.internal.rule.DisableSyntax could not be instantiated
[error] 	at java.util.ServiceLoader.fail(ServiceLoader.java:232)
[error] 	at java.util.ServiceLoader.access$100(ServiceLoader.java:185)
[error] 	at java.util.ServiceLoader$LazyIterator.nextService(ServiceLoader.java:384)
[error] 	at java.util.ServiceLoader$LazyIterator.next(ServiceLoader.java:404)
[error] 	at java.util.ServiceLoader$1.next(ServiceLoader.java:480)
[error] 	at scala.collection.convert.JavaCollectionWrappers$JIteratorWrapper.next(JavaCollectionWrappers.scala:38)
[error] 	at scala.collection.immutable.List.prependedAll(List.scala:153)
[error] 	at scala.collection.IterableOnceOps.toList(IterableOnce.scala:1251)
[error] 	at scala.collection.IterableOnceOps.toList$(IterableOnce.scala:1251)
[error] 	at scala.collection.AbstractIterator.toList(Iterator.scala:1293)
[error] 	at scalafix.internal.v1.Rules$.all(Rules.scala:104)
[error] 	at scalafix.internal.v1.Rules$.all(Rules.scala:99)
[error] 	at docs.RuleModifier.<init>(RuleModifier.scala:11)
[error] 	at docs.Main$.main(Main.scala:55)
[error] 	at docs.Main.main(Main.scala)
[error] Caused by: java.lang.NoSuchMethodError: pprint.TPrint$.literal(Ljava/lang/String;)Lpprint/TPrint;
[error] 	at scalafix.internal.rule.DisableSyntaxConfig$.<clinit>(DisableSyntaxConfig.scala:112)
[error] 	at scalafix.internal.rule.DisableSyntax.<init>(DisableSyntax.scala:14)

It looks like com-lihaoyi/PPrint#72 strikes again 😢

Let's retest this after #1530 is merged, as DisableSyntaxConfig should link against the shaded version of pprint and thus be independent of what mdoc evicts.

@bjaglin bjaglin force-pushed the update/mdoc-2.3.0 branch 2 times, most recently from 0a35daf to fc37a6b Compare February 14, 2022 11:41
@bjaglin
Copy link
Collaborator

bjaglin commented Feb 14, 2022

Let's retest this after #1530 is merged, as DisableSyntaxConfig should link against the shaded version of pprint and thus be independent of what mdoc evicts.

It was not enough, as it turns out scalafix-rules directly uses pprint.TPrint, which is evicted to an incompatible version by mdoc. Fixing this in #1546.

@bjaglin bjaglin merged commit cbd7382 into scalacenter:main Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants