Translate java error positions into lines+columns #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Arthurm1 I think this would be better to PR into sbt/zinc to get it properly reviewed. We can try to port it here afterwards or maybe we will be able to do scalacenter/bloop#1383 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java errors/warnings currently have a single line number and file based start/end position info.
Bloop+Metals+VSCode requires start/end line + start/end column info to highlight correctly.
This PR translates the current info into the start/end line + start/end column info.
I've put in a few tests - I doubt I've covered all possibilities but currently java errors are just highlighted at a single line number with column zero so this should be better than that.
I dumped the reflection stuff because it was dumped here and made it easier for me - not sure if that was a good idea.
Is this the right place to submit the PR or should I be working against sbt/zinc what with scalacenter/bloop#1383?
Fixes scalacenter/bloop#1389