Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental exposition of Chimney derivation engine as a library to use by other libraries #574

Merged
merged 4 commits into from
Sep 25, 2024

Conversation

MateuszKubuszok
Copy link
Member

@MateuszKubuszok MateuszKubuszok commented Jul 18, 2024

See #573

TODO:

  • make sure the example compiles tests

  • make sure the code does not checks MiMa

  • add documentation in cookbook

  • explain that this library is experimental - Chimney checks with MiMa

    • chimney-macro-commons
    • public API of Chimney core module
    • integrations

    but Chimney core module's macros are not set in stone and can be modified in binary incompatible way.

@MateuszKubuszok MateuszKubuszok added the blocked Ticket cannot be implemented because it depends on another ticker or external factor label Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 86.52%. Comparing base (273e77c) to head (ae09536).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...himney/internal/compiletime/DerivationEngine.scala 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #574      +/-   ##
==========================================
- Coverage   86.57%   86.52%   -0.05%     
==========================================
  Files         154      155       +1     
  Lines        5995     6004       +9     
  Branches      544      543       -1     
==========================================
+ Hits         5190     5195       +5     
- Misses        805      809       +4     
Flag Coverage Δ
86.52% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MateuszKubuszok MateuszKubuszok force-pushed the macros-as-library branch 2 times, most recently from ae9ac04 to 7a54892 Compare September 25, 2024 12:14
@MateuszKubuszok MateuszKubuszok marked this pull request as ready for review September 25, 2024 13:23
@MateuszKubuszok MateuszKubuszok removed the blocked Ticket cannot be implemented because it depends on another ticker or external factor label Sep 25, 2024
@MateuszKubuszok MateuszKubuszok merged commit 361d4ce into master Sep 25, 2024
24 checks passed
@MateuszKubuszok MateuszKubuszok deleted the macros-as-library branch September 25, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant