Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EvaluatedMarkdownDocument interface #838

Merged
merged 4 commits into from
Jul 26, 2024

Conversation

keynmol
Copy link
Collaborator

@keynmol keynmol commented Feb 2, 2024

This is a proposal to discuss with other maintainers.

Adding this method allows managing multiple mdoc instance via classloaders, and in general makes the Mdoc interface cover the thing most people would use mdoc for - markdown documents.

I've already confirmed that with this PR it's possible to use mdoc through a filtering classloader to render markdown documents, even with custom classpath.

cc @tgodzik @olafurpg @ckipp01

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok with me! I was wondering if we should somehow merge it with the worksheets, but they seem much more complex.

Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻 This makes a lot of sense 👍🏻

@keynmol
Copy link
Collaborator Author

keynmol commented Feb 15, 2024

Thanks for approvals, I will add some very basic tests tomorrow to this PR and then we can merge.

- Add a method to java interfaces
- Implement EvaluatedMarkdownDocument class
- Update Mdoc implementation (currently in worksheets, but doesn't have
  to be)
@keynmol
Copy link
Collaborator Author

keynmol commented Jul 26, 2024

@tgodzik I added a basic test (after 5+ months...) - still good to go?

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! Let me know when you want a release LGTM

@tgodzik tgodzik merged commit 1291803 into scalameta:main Jul 26, 2024
14 checks passed
@keynmol keynmol deleted the markdown-interface branch July 26, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants