Upgrade dependencies #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be one of the last "upgrade ..." in a while since we intend to keep v4 stable.
jonas
reviewed
Sep 11, 2018
| @@ -38,6 +43,7 @@ before_install: | |||
| - nvm install "$TRAVIS_NODE_VERSION" | |||
| - curl -o- -L https://yarnpkg.com/install.sh | bash -s -- --version "$TRAVIS_YARN_VERSION" | |||
| - export PATH=$HOME/.yarn/bin:$PATH | |||
| - yarn config set ignore-engines true | |||
There was a problem hiding this comment.
I am curious, what was the reason for this?
There was a problem hiding this comment.
Good question! I encountered this error here facebook/create-react-app#4367 (comment) due to an error
error upath@1.0.4: The engine "node" is incompatible with this module. Expected version ">=4 <=9".
Opened #92 to properly document this in the contributing guide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be one of the last "upgrade ..." PRs since I'm hopeful v4 will be more stable than v3.