Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set rangeHoverProvider under experimental capabilities #3293

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

ayoub-benali
Copy link
Contributor

A workaround for microsoft/language-server-protocol#377 until it is resolved
this would allow LSP clients to explicitly know that they can send a range with textDocument/hover instead of a position

If someone has a better name for the field I am happy to change it :)

@ckipp01 should this be added to new-editor.md ?

A workaround for microsoft/language-server-protocol#377 until it is resolved
this would allow LSP clients to explicitly know that they can send a range with textDocument/hover instead of a position
Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, seems to do the trick 👍🏼

[Trace - 03:08:12 PM] Sending response 'initialize - (1)'. Processing request took 1445ms
Result: {
  "capabilities": {
    ...
    "experimental": {
      "rangeHoverProvider": true
    }
  },
  "serverInfo": {
    "name": "Metals",
    "version": "0.10.10-SNAPSHOT"
  }
}

As for the name, I think this is fine. Thanks for tackling this! I'll leave this open for a bit in case the others have any comments on it, but if not LGTM!

@ckipp01
Copy link
Member

ckipp01 commented Nov 16, 2021

@ckipp01 should this be added to new-editor.md ?

No I think we're good. Under hover we already mention this:

https://scalameta.org/metals/docs/integrations/new-editor/#textdocumenthover

@ckipp01 ckipp01 merged commit 30cc89e into scalameta:main Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants