improvement: don't fail on shortType
#7148
Conversation
| } | ||
| } catch { | ||
| case NonFatal(e) => | ||
| logger.warning(s"Failed to shorten type $longType: $e") |
There was a problem hiding this comment.
maybe wrap the exception with that info instead? that way, the stack trace will include both this message and everything else it normally does. Maybe even include the history parameter in there if that makes sense
There was a problem hiding this comment.
maybe wrap the exception with that info instead?
Are suggesting to add the info and rethrow?
One thing that I don't understand is how that error even surfaced like this. Errors inside of pc are caught and reported as error reports. What version of Scala was that exactly?
There was a problem hiding this comment.
Are suggesting to add the info and rethrow?
yep
What version of Scala was that exactly?
I don't even remember, but it could even have been a cross-compiled project with sbt-projectmatrix (meaning all build variants would have their bloop project created, and loaded into Metals) 😬
next time I hit this (or something similar), I'll make sure to gather more info.
There was a problem hiding this comment.
I don't want to throw here. If it throws, you'll get no competitions, and this is just shortening the type, so we can use the long type as fallback. But I will create a full error report here instead of just logging to get more info.
resolves: #7091
I added
PcQueryContextclass, so it can be implicitly passed between pc methods. This way we can easily create and error report with all the context information from any place in the presentation compiler.