Optimization: don't run timeout logic for non-async tests

scalameta · Oct 11, 2021 · 8a123cd · 8a123cd
1 parent cfc64be
commit 8a123cd
Showing 1 changed file with 20 additions and 15 deletions.
diff --git a/munit/jvm/src/main/scala/munit/internal/PlatformCompat.scala b/munit/jvm/src/main/scala/munit/internal/PlatformCompat.scala
@@ -33,21 +33,26 @@ object PlatformCompat {
       duration: Duration,
       ec: ExecutionContext
   ): Future[T] = {
-    val onComplete = Promise[T]()
-    var onCancel: () => Unit = () => ()
-    future.onComplete { result =>
-      onComplete.tryComplete(result)
-    }(ec)
-    val timeout = sh.schedule[Unit](
-      () =>
-        onComplete.tryFailure(
-          new TimeoutException(s"test timed out after $duration")
-        ),
-      duration.toMillis,
-      TimeUnit.MILLISECONDS
-    )
-    onCancel = () => timeout.cancel(false)
-    onComplete.future
+    if (future.value.isDefined) {
+      // Avoid heavy timeout overhead for non-async tests.
+      future
+    } else {
+      val onComplete = Promise[T]()
+      var onCancel: () => Unit = () => ()
+      future.onComplete { result =>
+        onComplete.tryComplete(result)
+      }(ec)
+      val timeout = sh.schedule[Unit](
+        () =>
+          onComplete.tryFailure(
+            new TimeoutException(s"test timed out after $duration")
+          ),
+        duration.toMillis,
+        TimeUnit.MILLISECONDS
+      )
+      onCancel = () => timeout.cancel(false)
+      onComplete.future
+    }
   }
 
   def isIgnoreSuite(cls: Class[_]): Boolean =