Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for all configuration to be handled in the config table. #234

Closed
ckipp01 opened this issue Oct 3, 2021 · 0 comments · Fixed by #278
Closed

Allow for all configuration to be handled in the config table. #234

ckipp01 opened this issue Oct 3, 2021 · 0 comments · Fixed by #278
Labels
task

Comments

@ckipp01
Copy link
Member

ckipp01 commented Oct 3, 2021 •
edited
Loading

Task

One legacy thing that still remains which I'd like to force out is that fact that you set the server version via vim.g["metals_server_version"]. The same goes with the metals_server_org. This is true for all of the metals-options:

  • metals_server_version
  • metals_server_org
  • metals_decoration_color
  • metals_disabled_mode
  • metals_use_global_executable

I'd like to phase these out in two steps:

  1. Introduce them all as values that can just be passed into the Metals config table
  2. Then remove them after the above has been completed for a while.

Additional context

The only real benefit of this is that all of the configuration can be done and handled in one place.
@ckipp01 ckipp01 added the task label Oct 3, 2021
@ckipp01 ckipp01 changed the title Allow for all customization to be handled in the config table. Allow for all configuration to be handled in the config table. Oct 5, 2021
ckipp01 added a commit to ckipp01/nvim-metals that referenced this issue Dec 4, 2021
@ckipp01
Add in the ability to automatically install latest snapshot.
d4fd52b 
This makes several different changes.

1. Introduces a new way to set the version to the latest snapshot. Instead of always
having to find the latest snapshot and manually set it, we instead pull it from the
maven-metadata.xml file and automaticaly use that. There has been issues in the past
with this not syncing as fast as you want, so it's not bullet-proof but should work
for most use cases. To use this just set your serverVersion as `SNAPSHOT`.

Closes scalameta#122

2. Starts work on scalameta#234. Not the preferred way to set your serverVersion or serverOrg
is to set it in the metals settings table, not as options.
@ckipp01 ckipp01 mentioned this issue Dec 4, 2021
Merged
ckipp01 added a commit to ckipp01/nvim-metals that referenced this issue Dec 4, 2021
@ckipp01
Add in the ability to automatically install latest snapshot.
1914661 
This makes several different changes.

1. Introduces a new way to set the version to the latest snapshot. Instead of always
having to find the latest snapshot and manually set it, we instead pull it from the
maven-metadata.xml file and automaticaly use that. There has been issues in the past
with this not syncing as fast as you want, so it's not bullet-proof but should work
for most use cases. To use this just set your serverVersion as `SNAPSHOT`.

Closes scalameta#122

2. Starts work on scalameta#234. Not the preferred way to set your serverVersion or serverOrg
is to set it in the metals settings table, not as options.
ckipp01 added a commit to ckipp01/nvim-metals that referenced this issue Dec 4, 2021
@ckipp01
Add in the ability to automatically install latest snapshot.
64ef44f 
This makes several different changes.

1. Introduces a new way to set the version to the latest snapshot. Instead of always
having to find the latest snapshot and manually set it, we instead pull it from the
maven-metadata.xml file and automaticaly use that. There has been issues in the past
with this not syncing as fast as you want, so it's not bullet-proof but should work
for most use cases. To use this just set your serverVersion as `SNAPSHOT`.

Closes scalameta#122

2. Starts work on scalameta#234. Not the preferred way to set your serverVersion or serverOrg
is to set it in the metals settings table, not as options.
ckipp01 added a commit to ckipp01/nvim-metals that referenced this issue Dec 4, 2021
@ckipp01
Add in disabledMode and useGlobalExecutable settings to the config ta…
125b5b8 
…ble.

This is now the preferred way to set these instead of using the
`g:metals_use_global_executable` and `g:metals_disabled_mode` options.

Closes scalameta#234
@ckipp01 ckipp01 mentioned this issue Dec 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add in disabledMode and useGlobalExecutable settings to the config table ckipp01/nvim-metals
1 participant
@ckipp01