Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suport for type on code selection. #232

Merged
merged 1 commit into from
Oct 9, 2021

Conversation

ckipp01
Copy link
Member

@ckipp01 ckipp01 commented Oct 3, 2021

This adds in initial support, but this issue in Metals
should be merged in first: scalameta/metals#3178.

Closes #228

@ckipp01 ckipp01 force-pushed the type-of-selection branch 2 times, most recently from 9b13441 to f29d6a7 Compare October 5, 2021 07:45
@ckipp01
Copy link
Member Author

ckipp01 commented Oct 5, 2021

I'm going to pause on this as I'm struggling with a good way to actually get this to work. Wait for an answer in neovim/neovim#15905

@ckipp01 ckipp01 force-pushed the type-of-selection branch 2 times, most recently from e9fe002 to b4c4d92 Compare October 9, 2021 14:08
This adds in initial support, but this issue in Metals
should be merged in first: scalameta/metals#3178.

Closes scalameta#228
@ckipp01 ckipp01 force-pushed the type-of-selection branch from b4c4d92 to d2f2095 Compare October 9, 2021 14:33
@ckipp01
Copy link
Member Author

ckipp01 commented Oct 9, 2021

Going to just go ahead and merge this with an example to use <Esc> in the mapping. Not idea since you lose the selection range, but I don't see a way round it for now.

@ckipp01 ckipp01 marked this pull request as ready for review October 9, 2021 14:36
@ckipp01 ckipp01 merged commit ab78a00 into scalameta:main Oct 9, 2021
@ckipp01 ckipp01 deleted the type-of-selection branch October 9, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for type annotation on code selection
1 participant