Simplify config cache and make bare_config a function. #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*NOTE* This commit contains a breaking change.
Previously when you were setting up your config table to pass into
`initialize_or_attach()` you'd start by creating a bare config like
this:
```lua
Metals_config = require("metals").bare_config
```
The problem with this was that the `bare_config` was just a table that
by you setting values to was actually mutating the `bare_config` table
internally. Since we'd like to keep that as a fresh bare config this
has been migrated to instead be a function that returns a bare config.
This means that where you are using `bare_config` you'll now want to
call it like so:
```lua
Metals_config = require("metals").bare_config()
```
Also, please subscribe to this discussion:
scalameta#253
All breaking changes will be listed there.
tymcauley
added a commit
to tymcauley/dotfiles
that referenced
this pull request
Oct 17, 2021
See here for more information:
scalameta/nvim-metals#255
nichobi
added a commit
to nichobi/dotfiles
that referenced
this pull request
Oct 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE This commit contains a breaking change.
Previously when you were setting up your config table to pass into
initialize_or_attach()you'd start by creating a bare config likethis:
The problem with this was that the
bare_configwas just a table thatby you setting values to was actually mutating the
bare_configtableinternally. Since we'd like to keep that as a fresh bare config this
has been migrated to instead be a function that returns a bare config.
This means that where you are using
bare_configyou'll now want tocall it like so:
Also, please subscribe to this discussion:
#253
All breaking changes will be listed there.