Better "Restart X" command names #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckipp01
requested changes
Apr 25, 2023
There was a problem hiding this comment.
Thanks @susliko! Just a nit, can you add a BREAKING CHANGE: description to the footer? Lots of nvim users will use packer and it picks up the various ways to indicate a breaking change using conventional commits and warns users when they update. Since this is technically a breaking change to the LUA API we'll want to make sure we do that here.
susliko
force-pushed
the
better-restart-command-names
branch
2 times, most recently
from
99190b9 to
f04ea0b
Compare
…_metals', 'restart_build' -> 'restart_build_server')
ckipp01
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #551
restart_serveris renamed torestart_metalsrestart_buildis renamed torestart_build_server