Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nativeImageRunAgent should depend on nativeImageCommand #37

Merged
merged 1 commit into from
Oct 13, 2021
Merged

nativeImageRunAgent should depend on nativeImageCommand #37

merged 1 commit into from
Oct 13, 2021

Conversation

i10416
Copy link
Contributor

@i10416 i10416 commented Oct 4, 2021

Running nativeImageRunAgent before nativeImage will fail due to
Could not find agent library native-image-agent on the library path
error. This is because running nativeImageRunAgent fetches graal-native, but does not run gu install native-image.

Thus, It should depend on nativeImageCommand to fetch missing dependencies.

Running `nativeImageRunAgent` before `nativeImage` will fail due to
`Could not find agent library native-image-agent on the library path`
error. Thus, it should depend on `nativeImageCommand` to fetch missing dependencies.
@i10416
Copy link
Contributor Author

i10416 commented Oct 12, 2021

@olafurpg
Hello.
Would you be kind enough to review PR when you have time?

Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you for this contribution!

@olafurpg olafurpg merged commit e1b63fe into scalameta:main Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants