Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove CMSClassUnloadingEnabled which doesn't work on 17 #61

Merged
merged 1 commit into from
Dec 23, 2022

Conversation

ckipp01
Copy link
Member

@ckipp01 ckipp01 commented Dec 22, 2022

Just merged in a couple prs and trying to get this up to date and 🟢 again in CI, but this was biting me locally.

@ckipp01 ckipp01 requested a review from tgodzik December 22, 2022 17:12
Copy link

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The jobs are failing, though it shouldn't be due to this change 🤔

@ckipp01
Copy link
Member Author

ckipp01 commented Dec 23, 2022

The jobs are failing, though it shouldn't be due to this change 🤔

Yea they've been failing for a while. I merge in #54 yesterday which was open for a long time, and it was all green when sent in, but isn't anymore. I'll slowly to to figure it out.

@ckipp01 ckipp01 merged commit 561d288 into scalameta:main Dec 23, 2022
@ckipp01 ckipp01 deleted the jdk17 branch December 23, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants