Avoid lookup up match for non-Token.Left{Brace,Paren} #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafurpg
commented
Jun 5, 2018
| case Modifier() => | ||
| // This case only applies to classes | ||
| next(f).right match { | ||
| case x @ (_: Token.LeftParen | _: Token.LeftBracket) => |
There was a problem hiding this comment.
The fix is ugly but it seems to do the job, feel free to refactor @pjrt I'm not sure exactly what this case is about
There was a problem hiding this comment.
Unn, I haven't looked at this code in a while. But it doesn't look any more ugly than the other stuff we need to do in this file :).
Closed
pjrt
approved these changes
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1203
cc/ @fommil