NeverInfixPattern: allow to match lhs as well #3705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
reviewed
Nov 27, 2023
| @@ -71,6 +71,6 @@ behaviour of "..." { | |||
| behavior.of("..." { | |||
There was a problem hiding this comment.
How is behavior actually matched here? The exclude filter has behaviour
There was a problem hiding this comment.
the exclude filter for prohibiting infix matches "behaviour" which is why only "behaviour" is not rewritten, and everything else (including "behavior" and "shouldBe") is.
There was a problem hiding this comment.
ach makes sense! I was thinking the other way around
There was a problem hiding this comment.
i know... i am frequently confused myself with the double negative ("never" and "exclude"), plus a little bit with neverInfix when used with AvoidInfix :)
tgodzik
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps with #3699.