Changed example line limit to agree with Intellij default and industr… #3707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samthebest please stop this. |
|
@samthebest Please respect the maintainers' decision. @kitbellew is the main contributor, who does the majority of work here (like 99%), so I trust him to make a proper decision. I don't think it's worth you time and effort. What would probably be better is raising a post on contributors discussing what would be the best starting configuration, which we would be able to put into recommendation at the start here. |
|
I raised a PR to make it more explicit that you should not use example configuration #3710 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason why 120 has long been the ubiquitously accepted convention is because Intellij IDE has been the longest ubiquitously accepted IDE for Scala, which came prior to scalafmt and which picks a default of 120 characters.
There are roughly 170 OS repositories that use 120 given by this approximate search: https://github.com/search?q=maxColumn+%3D+120&type=commits
Then about 33 for length 100 https://github.com/search?q=maxColumn+%3D+100&type=commits