Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to skip existing in release flow #11

Merged
merged 2 commits into from
Jul 15, 2021
Merged

Fix to skip existing in release flow #11

merged 2 commits into from
Jul 15, 2021

Conversation

tei-k
Copy link
Contributor

@tei-k tei-k commented Jul 14, 2021 •
edited
Loading

Description

https://scalar-labs.atlassian.net/browse/DLT-9382

When executing release workflow, it fails because it is trying to upload unchanged charts.

Looking up latest tag...
Discovering changed charts since 'scalardl-1.2.3'...
Installing chart-releaser...
Adding cr directory to PATH...
Packaging chart 'charts/scalardl'...
Successfully packaged chart in /home/runner/work/helm-charts/helm-charts/charts/scalardl and saved it to: .cr-release-packages/scalardl-1.2.3.tgz
Packaging chart 'charts/schema-loading'...
Successfully packaged chart in /home/runner/work/helm-charts/helm-charts/charts/schema-loading and saved it to: .cr-release-packages/schema-loading-1.3.1.tgz
Releasing charts...
Error: error creating GitHub release: POST https://api.github.com/repos/scalar-labs/helm-charts/releases: 422 Validation Failed [{Resource:Release Field:tag_name Code:already_exists Message:}]

Done

Confirm

Looking up latest tag...
Discovering changed charts since 'scalardl-1.2.3'...
Installing chart-releaser...
Adding cr directory to PATH...
Packaging chart 'charts/scalardl'...
Successfully packaged chart in /home/runner/work/scalardl-helm-charts/scalardl-helm-charts/charts/scalardl and saved it to: .cr-release-packages/scalardl-1.2.3.tgz
Packaging chart 'charts/schema-loading'...
Successfully packaged chart in /home/runner/work/scalardl-helm-charts/scalardl-helm-charts/charts/schema-loading and saved it to: .cr-release-packages/schema-loading-1.3.1.tgz
Releasing charts...
Updating charts repo index...
Using existing index at .cr-index/index.yaml
Found scalardl-1.2.3.tgz
Found schema-loading-1.3.1.tgz
Extracting chart metadata from .cr-release-packages/schema-loading-1.3.1.tgz
Calculating Hash for .cr-release-packages/schema-loading-1.3.1.tgz
Updating index .cr-index/index.yaml
Preparing worktree (detached HEAD b3f320d)

@tei-k tei-k self-assigned this Jul 14, 2021
@tei-k tei-k marked this pull request as ready for review July 15, 2021 01:47
@tei-k tei-k requested review from feeblefakie and ymorimo July 15, 2021 01:47
feeblefakie
feeblefakie approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ymorimo
ymorimo approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@ymorimo ymorimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@feeblefakie feeblefakie merged commit cd59731 into main Jul 15, 2021
@feeblefakie feeblefakie deleted the skip-existing-release branch July 15, 2021 06:33
tei-k added a commit that referenced this pull request Jul 15, 2021
@tei-k
Fix to skip existing in release flow (#11)
025957c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feeblefakie feeblefakie feeblefakie approved these changes

@ymorimo ymorimo ymorimo approved these changes

Assignees

@tei-k tei-k

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tei-k @ymorimo @feeblefakie