-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Fix SQLServer 2017 job #2250
Conversation
d685a10
to
7ddc4a6
Compare
@@ -1055,7 +1055,7 @@ jobs: | |||
|
|||
integration-test-for-jdbc-sqlserver-2017: | |||
name: SQL Server 2017 integration test (${{ matrix.mode.label }}) | |||
runs-on: ubuntu-latest | |||
runs-on: ubuntu-20.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we need the same change for integration-test-for-jdbc-sqlserver-2019
and integration-test-for-jdbc-sqlserver-2022
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other SQL Server versions do not seem affected by this bug so I kept them as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for fixing it! 🙇♀️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
# Conflicts: # .github/workflows/ci.yaml
# Conflicts: # .github/workflows/ci.yaml
# Conflicts: # .github/workflows/ci.yaml
# Conflicts: # .github/workflows/ci.yaml
Description
The CI job for SQLServer 2017 has been failing since the end of last week. It appears the SQLServer 2017 Docker container fails to start properly, cf. the logs in the "Additional notes” section below.
As a workaround, I downgraded the Github runner Ubuntu version from 22 to 20.
Related issues and/or PRs
Changes made
Downgraded the CI Github runner Ubuntu version from 22 to 20 for the SQLServer2017 job to fix a container startup issue.
Checklist
Additional notes (optional)
The logs for the SQLServer2017 Docker container which fails to start:
Release notes
N/A