This repository has been archived by the owner on Aug 28, 2024. It is now read-only.
fix(#31): set default version temporarily #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffgscott
approved these changes
Mar 11, 2024
amritk
changed the title
…sing info.version
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous parser never used to throw on missing info.version, however this one does. The spec DOES say info.version is required but we should bubble this error up and display it + continue to render the spec as it should not be blocking.
This PR is a very temp hot fix to get this parser to match the previous one's behavior. We should follow up and add a proper non-blocking, error bubbling strategy (if one does not exist).
closes #21