change firefox driver constructor for compatibility with newer versions #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cla-bot[bot] check |
|
Hi @NikolajsCmihuns, we require contributors to sign our Contributor License Agreement, and we don't have yours on file. In order for us to review and merge your code, please access https://www.artima.com/cla/choose-type to sign our Contributor License Agreement. Your effort is highly appreciated. Thank you. |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
@cla-bot[bot] check |
|
The cla-bot has been summoned, and re-checked this pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, discovered that FirefoxDriver contructor
public FirefoxDriver(FirefoxProfile profile)in 3.0.x branches is from selenium-firefox-driver:2.45.0 version (which is too old) and no longer exists in newer selenium versions. In modern projects version of selenium-firefox-driver will be higher and when initialisation of FirefoxDriver happens, then NoSuchMethodError is thrown.So with this pull request i suggest to use default non-arg constructor
@bvenners @cheeseng Maybe we can update selenium versions in scalatest project itself ?