-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed building scalatests on scala-native-2.13 #1922
base: 3.2.x-new
Are you sure you want to change the base?
Conversation
This commit fixed a future issue with scala-native that can be discovered inside current scala-native master because it supports scala-2.13 :)
@catap Er, I wonder is there no plan to support scala-xml in scala-native? scala-js does seem supports it in release 1.3.0 and 2.0.0-M2 for scala-js 0.6 and 1. |
@cheeseng at least it hasn't got scala-xml_2.13 for 1.0.6 :) |
@cheeseng BTW I haven't see :( |
@catap Ha, actually for 2.13 I can't find scala-native on maven repo, too. :) |
@cheeseng scala native hasn't yet released and 2.12 and 2.13 are available only from master as snapshot ;) |
@catap Not seeing it being included in scala-xml build: https://github.com/scala/scala-xml/blob/master/build.sbt#L164 May be first step will be to try add native build to scala-xml, not sure how hard it will be though. |
@cheeseng so, if it hasn't included how does it works? :) |
@cheeseng Looks like it never was includes: scala/scala-xml#282 So, I don't understand how it works right now. |
@catap It seems like the reason they dropped SN support is due to it requires scala 2.12, which SN did not support, but now 2.12 support is coming in master, right? |
@cheeseng and 2.13 also. But I have no idea when the master will be released. Here is the loop: I'm using quite complex project (its unit test) to find a bug inside scala-native master to help the team to release 2.12/2.13 without bugs [you can check the issue, I did find a few deep things, and a few inisde SJS by this code base]. All this unit tests are implemented on scalatests and right now I'm in the loop. But I feel that start to broke it from adding support of SN to scala-xml is good idea but it can't be done until SN is released :) |
@cheeseng I've touched scala-xml a bit and it seems isn't easy to make optional SN support. Special that a new SN is planned to release on this year I'd like to wait until it is released :) I will back to this PR ASAP |
not that I know of other than the "pull request welcome" here: scala/scala-xml#282 |
@SethTisue until SN is released with support 2.12 and 2.13 it is impossibly. I've tried make cross compilation with optionally enabled SN, but it is quite a challenge that doesn't seems worth to be solved because the release should be in months. |
This also quite old and seem to not be needed. @cheeseng shall I close it? |
This commit fixed a future issue with scala-native that can be discovered inside current scala-native master because it supports scala-2.13 :)