Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support scala-native #1322

Merged
merged 1 commit into from
Mar 4, 2017
Merged

support scala-native #1322

merged 1 commit into from
Mar 4, 2017

Conversation

xuwei-k
Copy link
Member

@xuwei-k xuwei-k commented Feb 26, 2017

@@ -1,5 +1,11 @@
scalacOptions += "-deprecation"

addSbtPlugin("org.scala-native" % "sbt-crossproject" % "0.1.0")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sbt-scala-native depends on sbt-crossproject you can remove this line if you want to.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. removed 😃

@MasseGuillaume
Copy link

MasseGuillaume commented Feb 26, 2017

@xuwei-k really good. You can run the sbt task nativeMissingDependencies to see if anything is missing at link time and create issues against scala-native.

> show coreNative/nativeMissingDependencies
[info] List(@java.lang.Throwable::init_class.java.lang.String_class.java.lang.Throwable_bool_bool)
[success] Total time: 12 s, completed Feb 26, 2017 11:29:04 AM

> show effectNative/nativeMissingDependencies
[info] List(@java.sql.Connection, @java.sql.Connection::close_unit, @java.sql.PreparedStatement, @java.sql.ResultSet, @java.sql.ResultSet::close_unit, @java.sql.Statement, @java.sql.Statement::close_unit)

> show iterateeNative/nativeMissingDependencies
[info] List()

for example, scala-native/scala-native#435

I'm not sure if we will implement java.sql.*

@xuwei-k
Copy link
Member Author

xuwei-k commented Mar 3, 2017

I will remove java.sql instances #1324

Copy link
Member

@S11001001 S11001001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neato.

@xuwei-k xuwei-k force-pushed the scala-native branch 2 times, most recently from 38f90ff to 5b0cb53 Compare March 3, 2017 15:50
@xuwei-k xuwei-k merged commit 6d7bfa8 into scalaz:series/7.3.x Mar 4, 2017
@xuwei-k xuwei-k deleted the scala-native branch March 4, 2017 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants