Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(aps): update docs apple silicon #2322

Merged
merged 8 commits into from
Nov 8, 2023
Merged

docs(aps): update docs apple silicon #2322

merged 8 commits into from
Nov 8, 2023

Conversation

bene2k1
Copy link
Member

@bene2k1 bene2k1 commented Oct 26, 2023

Your checklist for this pull request

Description

Please describe what you added or changed.

@bene2k1 bene2k1 self-assigned this Oct 26, 2023
@bene2k1 bene2k1 added the do not merge PR that shouldn't be merged before a specific date (eg release) label Oct 26, 2023
jsudraud
jsudraud approved these changes Nov 3, 2023
View reviewed changes
bare-metal/apple-silicon/how-to/reinstall-mac-mini.mdx Outdated Show resolved Hide resolved
bare-metal/apple-silicon/how-to/reinstall-mac-mini.mdx Outdated Show resolved Hide resolved
bare-metal/apple-silicon/quickstart.mdx Outdated Show resolved Hide resolved
bare-metal/apple-silicon/quickstart.mdx Outdated Show resolved Hide resolved
bare-metal/apple-silicon/quickstart.mdx Outdated Show resolved Hide resolved
bare-metal/apple-silicon/quickstart.mdx Outdated Show resolved Hide resolved
@bene2k1 bene2k1 marked this pull request as ready for review November 3, 2023 11:07
bene2k1 and others added 2 commits November 3, 2023 12:08
@bene2k1
docs(aps): fixed broken file name
5b969da
@bene2k1 @jsudraud
Apply suggestions from code review
704f4a8 
Co-authored-by: Justine Sudraud <124775951+jsudraud@users.noreply.github.com>
@bene2k1 bene2k1 added the status: tech review Waiting for technical review label Nov 3, 2023
@scwgoire
Copy link
Collaborator

scwgoire commented Nov 6, 2023

Looks nice, 2 remarks:

  • what's the value in telling the macs are mac minis? I don't think it hurt but it doesn't seem to help either
  • please hold the MR until we resolve the ongoing discussions about the upcoming products (cf Slack)

@bene2k1 bene2k1 removed do not merge PR that shouldn't be merged before a specific date (eg release) status: tech review Waiting for technical review labels Nov 8, 2023
@bene2k1 bene2k1 merged commit bf8c204 into main Nov 8, 2023
2 of 3 checks passed
@bene2k1 bene2k1 deleted the MTA-3841 branch November 8, 2023 09:34
nerda-codes pushed a commit that referenced this pull request Nov 27, 2023
@bene2k1 @nerda-codes
docs(aps): update docs apple silicon (#2322)
b6939e8
nerda-codes pushed a commit that referenced this pull request Nov 28, 2023
@bene2k1 @nerda-codes
docs(aps): update docs apple silicon (#2322)
cae4a25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsudraud jsudraud jsudraud approved these changes

@nerda-codes nerda-codes nerda-codes approved these changes

@ldecarvalho-doc ldecarvalho-doc Awaiting requested review from ldecarvalho-doc

@SamyOubouaziz SamyOubouaziz Awaiting requested review from SamyOubouaziz SamyOubouaziz is a code owner

Assignees

@bene2k1 bene2k1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bene2k1 @scwgoire @nerda-codes @jsudraud