Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vpc-gw):add support wait vpcGwGatewayNetworkDelete #3675

Merged

Conversation

Laure-di
Copy link
Contributor

No description provided.

@Laure-di Laure-di force-pushed the fix/add-wait-support-delete-gw-network branch from 78cf73d to fb631eb Compare February 22, 2024 15:43
@Laure-di Laure-di marked this pull request as draft February 22, 2024 15:44
@Laure-di Laure-di marked this pull request as ready for review February 23, 2024 09:28
@Laure-di Laure-di force-pushed the fix/add-wait-support-delete-gw-network branch from fb631eb to 32aff4e Compare February 23, 2024 13:43
@Laure-di Laure-di self-assigned this Feb 23, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 13.04348% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 75.81%. Comparing base (d173433) to head (32aff4e).

Files Patch % Lines
...rnal/namespaces/vpcgw/v1/custom_gateway_network.go 9.09% 19 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3675      +/-   ##
==========================================
- Coverage   75.84%   75.81%   -0.04%     
==========================================
  Files         190      190              
  Lines       42617    42640      +23     
==========================================
+ Hits        32324    32327       +3     
- Misses       9104     9123      +19     
- Partials     1189     1190       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Codelax Codelax added this pull request to the merge queue Feb 23, 2024
Merged via the queue into scaleway:master with commit 23ed688 Feb 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants