feat(core): set can handle all positional args together #3722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3722 +/- ##
==========================================
+ Coverage 75.45% 77.12% +1.67%
==========================================
Files 202 202
Lines 44323 37142 -7181
==========================================
- Hits 33444 28646 -4798
+ Misses 9653 7267 -2386
- Partials 1226 1229 +3 ☔ View full report in Codecov by Sentry. |
2 tasks
Mia-Cross
force-pushed
the
core_set_with_all_positional_args
branch
from
4dc793d to
4fd35a5
Compare
Mia-Cross
force-pushed
the
core_set_with_all_positional_args
branch
4 times, most recently
from
7f5c3d8 to
dc6c4c0
Compare
Codelax
reviewed
Apr 8, 2024
Mia-Cross
force-pushed
the
core_set_with_all_positional_args
branch
from
0bf80a5 to
8067653
Compare
Codelax
reviewed
Apr 9, 2024
Co-authored-by: Jules Castéran <jules.casteran@gmail.com>
Codelax
approved these changes
Apr 9, 2024
jremy42
pushed a commit
to jremy42/scaleway-cli
that referenced
this pull request
Apr 12, 2024
Co-authored-by: Jules Castéran <jules.casteran@gmail.com>
Laure-di
pushed a commit
to Laure-di/scaleway-cli
that referenced
this pull request
Apr 16, 2024
Co-authored-by: Jules Castéran <jules.casteran@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new behavior for the
setverb when there are several positional arguments.This feature will be helpful for #3597 but for now, there is no
setcommand that is using positional arguments, so the test in this PR only shows that the already existing commands withsetstill work. More tests will be added in #3597.