Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add support for gocritic #4063

Merged
merged 6 commits into from
Aug 22, 2024
Merged

chore: add support for gocritic #4063

merged 6 commits into from
Aug 22, 2024

Conversation

remyleone
Copy link
Member

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


@github-actions github-actions bot added rdb Managed MySQL and PostgreSQL issues, bugs and feature requests instance Instance issues, bugs and feature requests k8s Kubernetes Kapsule issues, bugs and feature requests redis Managed Redis issues, bugs and feature requests iam IAM issues, bugs and feature requests billing Billing issues, bugs and feature requests baremetal labels Aug 21, 2024
@github-actions github-actions bot removed the iam IAM issues, bugs and feature requests label Aug 22, 2024
Codelax
Codelax previously approved these changes Aug 22, 2024
@Codelax Codelax enabled auto-merge August 22, 2024 15:59
@Codelax Codelax added this pull request to the merge queue Aug 22, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 42.00000% with 29 lines in your changes missing coverage. Please review.

Project coverage is 69.40%. Comparing base (5bf53e0) to head (a6e7275).
Report is 211 commits behind head on master.

Files Patch % Lines
cmd/scw/main.go 0.00% 4 Missing ⚠️
internal/core/command.go 0.00% 4 Missing ⚠️
internal/core/shell.go 0.00% 4 Missing ⚠️
internal/core/command_interceptor.go 0.00% 1 Missing and 1 partial ⚠️
internal/interactive/prompt.go 0.00% 2 Missing ⚠️
internal/namespaces/autocomplete/errors.go 0.00% 2 Missing ⚠️
...espaces/billing/v2beta1/custom_invoice_download.go 0.00% 2 Missing ⚠️
...amespaces/billing/v2beta1/custom_invoice_export.go 0.00% 2 Missing ⚠️
internal/core/autocomplete_utils.go 0.00% 1 Missing ⚠️
internal/core/testing.go 50.00% 1 Missing ⚠️
... and 5 more

❗ There is a different number of reports uploaded between BASE (5bf53e0) and HEAD (a6e7275). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5bf53e0) HEAD (a6e7275)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4063      +/-   ##
==========================================
- Coverage   75.45%   69.40%   -6.05%     
==========================================
  Files         202      291      +89     
  Lines       44323    55630   +11307     
==========================================
+ Hits        33444    38612    +5168     
- Misses       9653    15441    +5788     
- Partials     1226     1577     +351     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into scaleway:master with commit 2de0b33 Aug 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
baremetal billing Billing issues, bugs and feature requests instance Instance issues, bugs and feature requests k8s Kubernetes Kapsule issues, bugs and feature requests rdb Managed MySQL and PostgreSQL issues, bugs and feature requests redis Managed Redis issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants