Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apple-silicon): add contract message information #4405

Closed

Conversation

Laure-di
Copy link
Contributor

@Laure-di Laure-di commented Jan 8, 2025

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


@github-actions github-actions bot added the apple-silicon Apple Silicon issues, bugs and feature requests label Jan 8, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 5.00000% with 19 lines in your changes missing coverage. Please review.

Project coverage is 70.79%. Comparing base (5bf53e0) to head (147fe62).
Report is 458 commits behind head on master.

Files with missing lines Patch % Lines
.../namespaces/applesilicon/v1alpha1/custom_server.go 5.00% 18 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4405      +/-   ##
==========================================
- Coverage   75.45%   70.79%   -4.67%     
==========================================
  Files         202      299      +97     
  Lines       44323    66370   +22047     
==========================================
+ Hits        33444    46986   +13542     
- Misses       9653    17732    +8079     
- Partials     1226     1652     +426     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Laure-di Laure-di force-pushed the apple-silicon-contract-message branch from c0d9594 to 04d2609 Compare January 8, 2025 13:32
@github-actions github-actions bot added rdb Managed MySQL and PostgreSQL issues, bugs and feature requests load-balancer Load-balancer issues, bugs and feature requests instance Instance issues, bugs and feature requests vpc Virtual Private Cloud (VPC) issues, bugs and feature requests container Container issues, bugs and feature requests iam IAM issues, bugs and feature requests tem Transactional Email issues, bugs and feature requests labels Jan 27, 2025
@Laure-di Laure-di force-pushed the apple-silicon-contract-message branch 2 times, most recently from 45d58ac to bfff751 Compare January 27, 2025 09:13
@github-actions github-actions bot removed rdb Managed MySQL and PostgreSQL issues, bugs and feature requests load-balancer Load-balancer issues, bugs and feature requests instance Instance issues, bugs and feature requests vpc Virtual Private Cloud (VPC) issues, bugs and feature requests container Container issues, bugs and feature requests iam IAM issues, bugs and feature requests tem Transactional Email issues, bugs and feature requests labels Jan 27, 2025
@Laure-di Laure-di force-pushed the apple-silicon-contract-message branch from bfff751 to 5a1ac2e Compare January 27, 2025 09:23
@Laure-di Laure-di force-pushed the apple-silicon-contract-message branch from 5a1ac2e to 1da1985 Compare January 27, 2025 13:09
@Laure-di Laure-di marked this pull request as draft January 27, 2025 15:02
@remyleone remyleone closed this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apple-silicon Apple Silicon issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants