Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove boolean without value in args #767

Merged
merged 5 commits into from
Mar 12, 2020
Merged

chore: remove boolean without value in args #767

merged 5 commits into from
Mar 12, 2020

Conversation

loicbourgois
Copy link
Contributor

No description provided.

@loicbourgois loicbourgois changed the title wip: chore: remove boolean without value in args chore: remove boolean without value in args Mar 11, 2020
kindermoumoute
kindermoumoute reviewed Mar 11, 2020
View reviewed changes
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it should return a CliError with a hint:

scw stuff create string=plop bool int=3
Error: arg 'bool' must have a value
Hint: try running: `scw stuff create string=plop bool=true int=3`

kindermoumoute
kindermoumoute approved these changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loicbourgois loicbourgois merged commit d8094d3 into scaleway:v2 Mar 12, 2020
@loicbourgois loicbourgois deleted the APIGW-1901 branch March 12, 2020 15:40
clement-gilbert pushed a commit to clement-gilbert/scaleway-cli that referenced this pull request Mar 3, 2022
@remyleone
doc: use project id instead or organization id in migration guide (sc…
3d8682b 
…aleway#767)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kindermoumoute kindermoumoute kindermoumoute approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loicbourgois @kindermoumoute