Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lb): make loadbalancer fallback name lookup honor zone annotation #160

Merged
merged 4 commits into from
Feb 6, 2024

Conversation

Nox-404
Copy link
Contributor

@Nox-404 Nox-404 commented Feb 5, 2024

No description provided.

@Nox-404
Copy link
Contributor Author

Nox-404 commented Feb 5, 2024

This PR will try to honor the zone annotation if provided when using the name lookup fallback.
It will help to fix #158, but the two controllers might still fight to update the annotations.

pablo-ruth
pablo-ruth previously approved these changes Feb 6, 2024
Copy link
Contributor

@pablo-ruth pablo-ruth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@pablo-ruth pablo-ruth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re LGTM

@Nox-404 Nox-404 merged commit f8f238c into scaleway:master Feb 6, 2024
5 checks passed
Nox-404 added a commit that referenced this pull request Feb 6, 2024
…#160)

* fix(lb): make loadbalancer fallback name lookup honor zone annotation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants