fix(serverless): remove usage of domain_name in create and update (#1339

) Co-authored-by: Rémy Léone <rleone@scaleway.com>
scaleway · Jul 6, 2022 · 00c3c36 · 00c3c36
1 parent 6041f36
commit 00c3c36
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/api/container/v1beta1/container_sdk.go b/api/container/v1beta1/container_sdk.go
@@ -1202,8 +1202,6 @@ type CreateContainerRequest struct {
 	RegistryImage *string `json:"registry_image"`
 
 	MaxConcurrency *uint32 `json:"max_concurrency"`
-
-	DomainName *string `json:"domain_name"`
 	// Protocol:
 	//
 	// Default value: unknown_protocol
@@ -1287,8 +1285,6 @@ type UpdateContainerRequest struct {
 	RegistryImage *string `json:"registry_image"`
 
 	MaxConcurrency *uint32 `json:"max_concurrency"`
-
-	DomainName *string `json:"domain_name"`
 	// Protocol:
 	//
 	// Default value: unknown_protocol
@@ -1756,6 +1752,7 @@ type ListDomainsRequest struct {
 	ContainerID string `json:"-"`
 }
 
+// ListDomains: list all domain name bindings
 func (s *API) ListDomains(req *ListDomainsRequest, opts ...scw.RequestOption) (*ListDomainsResponse, error) {
 	var err error
 
@@ -1804,6 +1801,7 @@ type GetDomainRequest struct {
 	DomainID string `json:"-"`
 }
 
+// GetDomain: get a domain name binding
 func (s *API) GetDomain(req *GetDomainRequest, opts ...scw.RequestOption) (*Domain, error) {
 	var err error
 
@@ -1846,6 +1844,7 @@ type CreateDomainRequest struct {
 	ContainerID string `json:"container_id"`
 }
 
+// CreateDomain: create a domain name binding
 func (s *API) CreateDomain(req *CreateDomainRequest, opts ...scw.RequestOption) (*Domain, error) {
 	var err error
 
@@ -1887,6 +1886,7 @@ type DeleteDomainRequest struct {
 	DomainID string `json:"-"`
 }
 
+// DeleteDomain: delete a domain name binding
 func (s *API) DeleteDomain(req *DeleteDomainRequest, opts ...scw.RequestOption) (*Domain, error) {
 	var err error
 

diff --git a/api/function/v1beta1/function_sdk.go b/api/function/v1beta1/function_sdk.go
@@ -733,6 +733,8 @@ type Function struct {
 
 	Description *string `json:"description"`
 
+	DomainName string `json:"domain_name"`
+
 	SecretEnvironmentVariables []*SecretHashedValue `json:"secret_environment_variables"`
 
 	Region scw.Region `json:"region"`
@@ -1975,6 +1977,7 @@ type ListDomainsRequest struct {
 	FunctionID string `json:"-"`
 }
 
+// ListDomains: list all domain name bindings
 func (s *API) ListDomains(req *ListDomainsRequest, opts ...scw.RequestOption) (*ListDomainsResponse, error) {
 	var err error
 
@@ -2023,6 +2026,7 @@ type GetDomainRequest struct {
 	DomainID string `json:"-"`
 }
 
+// GetDomain: get a domain name binding
 func (s *API) GetDomain(req *GetDomainRequest, opts ...scw.RequestOption) (*Domain, error) {
 	var err error
 
@@ -2065,6 +2069,7 @@ type CreateDomainRequest struct {
 	FunctionID string `json:"function_id"`
 }
 
+// CreateDomain: create a domain name binding
 func (s *API) CreateDomain(req *CreateDomainRequest, opts ...scw.RequestOption) (*Domain, error) {
 	var err error
 
@@ -2106,6 +2111,7 @@ type DeleteDomainRequest struct {
 	DomainID string `json:"-"`
 }
 
+// DeleteDomain: delete a domain name binding
 func (s *API) DeleteDomain(req *DeleteDomainRequest, opts ...scw.RequestOption) (*Domain, error) {
 	var err error