Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(client): add WithZones and WithRegions options #1416

Merged
merged 14 commits into from
Oct 4, 2022
Merged

feat(client): add WithZones and WithRegions options #1416

merged 14 commits into from
Oct 4, 2022

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Sep 20, 2022 •
edited
Loading

Complete region

servers, err := api.ListServers(&instance.ListServersRequest{},
	scw.WithZones(scw.RegionFrPar.GetZones()...),
)

Specific zones

servers, err := api.ListServers(&instance.ListServersRequest{},
	scw.WithZones(scw.ZoneFrPar1, scw.ZoneFrPar2, scw.ZoneNlAms1),
)

All zones

servers, err := api.ListServers(&instance.ListServersRequest{},
	scw.WithZones(scw.AllZones...),
)

@Codelax Codelax changed the title feat(client): add zone sweeper feat(client): add zone sweeper opt Sep 20, 2022
@Codelax Codelax marked this pull request as ready for review September 22, 2022 12:50
remyleone
remyleone reviewed Sep 22, 2022
View reviewed changes
scw/client.go Outdated Show resolved Hide resolved
scw/client.go Outdated Show resolved Hide resolved
Monitob
Monitob reviewed Sep 22, 2022
View reviewed changes
scw/client.go Outdated Show resolved Hide resolved
scw/client.go Outdated Show resolved Hide resolved
scw/client.go Show resolved Hide resolved
scw/client.go Outdated Show resolved Hide resolved
scw/client.go Show resolved Hide resolved
scw/client.go Outdated Show resolved Hide resolved
@Codelax Codelax self-assigned this Sep 23, 2022
@Codelax Codelax changed the title feat(client): add zone sweeper opt feat(client): add WithZones and WithRegions options Sep 27, 2022
Monitob
Monitob reviewed Sep 29, 2022
View reviewed changes
scw/client.go Show resolved Hide resolved
@Codelax Codelax merged commit 390219e into scaleway:master Oct 4, 2022
@Codelax Codelax deleted the sweeper_opt branch October 4, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyleone remyleone remyleone left review comments

@Monitob Monitob Monitob approved these changes

Assignees

@Codelax Codelax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Codelax @remyleone @Monitob